feat: support styling via home assistant themes#36
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds comprehensive support for styling the weather forecast card through Home Assistant themes. It introduces 31 customizable CSS variables (17 main card variables and 17 weather effects variables) that allow users to customize colors, sizes, and visual elements through their Home Assistant theme configuration.
Key Changes:
- Wraps all internal CSS variables with public theme variable names following the
weather-forecast-card-*naming convention - Adds comprehensive test suite to verify all theme variables are properly defined and referenced in CSS files
- Updates README with complete documentation of all available theme variables, including example configurations
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/weather-forecast-card-styles.test.ts | New comprehensive test suite that validates all theme variables are correctly defined and referenced in CSS files |
| src/weather-forecast-card.css | Updates internal CSS variables to support public theme variable overrides with proper fallback chains |
| src/components/animation/wfc-animation.css | Updates animation-related CSS variables to support public theme variable overrides for weather effects |
| README.md | Adds comprehensive styling documentation with complete tables of all 31 available theme variables and usage examples |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR completes the support of styling via home assistant themes.
Closes #33.